Enable setting the count prior for empty droplets #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for contributing this @niklasmueboe ! Actually though, I've been working to do (what I think is) the exact same thing myself. That version is now included in v0.3.0 The new input arguments are called So for now, I will mark this as closed by #238 |
|
But please let me know if the fix in v0.3.0 doesn't work for you, and we can look into re-opening this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would allow to let the user set the prior on the RNA counts of empty droplets in the CLI. This is useful if the estimation using the mode of the log(counts) does not give a reasonable estimate.